feat: Routing.Type=auto (DHT+IPNI) #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Dec 7, 2022
lidel
commented
Dec 7, 2022
lidel
force-pushed
the
feat/implicit-routing-defaults
branch
from
682c21e
to
57b98fe
Compare
This changes the default routing to to be implicit DHT+IPNI Full context: #9422 (comment)
Based on feedback from #9475
lidel
force-pushed
the
feat/implicit-routing-defaults
branch
from
57b98fe
to
e65885a
Compare
lidel
commented
Dec 7, 2022
guseggert
reviewed
Dec 7, 2022
BigLep
reviewed
Dec 7, 2022
lidel
added a commit
to ipfs/fs-repo-migrations
that referenced
this pull request
Dec 7, 2022
9 tasks
BigLep
reviewed
Dec 8, 2022
lidel
commented
Dec 8, 2022
|
Defaulting to cid.contact breaks private networks feature – leaking private CIDs to public HTTP endpoint, and/or learning about providers which are useless due to the lack of shared key. I will add a check that tries to swithc to dht-only, and if that fails refuses to start with |
lidel
added a commit
that referenced
this pull request
Dec 8, 2022
lidel
force-pushed
the
feat/implicit-routing-defaults
branch
from
15fd9b1
to
753b3da
Compare
|
Resolved, ready for final review @BigLep @guseggert |
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
IPNI enabled by default made tests fail due to false-negative: Kubo was able to find provider for "foo" "bar" thanks to IPNI. This ensures data is unique enough to have no providers.
lidel
added a commit
to ipfs/fs-repo-migrations
that referenced
this pull request
Dec 9, 2022
3 tasks
This was referenced Jan 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Kubo will now use DHT and IPNI at cid.contact at the same time.
This PR results in faster lookup times from IPNI for most use cases on average, while still maintaining the resiliency of DHT.
I've been running this for a while and end users should see a positive change in the time it takes to load DNSLink websites, or lookup a provider for a CID.
Closes #9454 Closes #9422
Details
Routing.Typefrom user config (it is not implicit)Routing.TypefromdhttoautoRouting.Type=autoto ask DHT and IPNI at cid.contact in parallelFull context: #9422 (comment)
TODO before merge
TimeoutandIgnoreErrorfor DHT and IPNI routersRouting.Type="dht"and removeRouting.Typeto switch users to the new default)